Backup App migration #9602
Backup App migration #9602
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
packages/web-pkg/src/composables/resourcesViewDefaults/useResourcesViewDefaults.ts
Outdated
Show resolved
Hide resolved
…avigation.vue with slot
# Conflicts: # packages/web-pkg/src/composables/index.ts # pnpm-lock.yaml
There was a problem hiding this comment.
Getting there, nice 🥳 Some open tasks:
- Remove the moved files from the files-app
- Adjust all affected imports
- Move test
*.spec.tsfiles accordingly - Linter seems to be unhappy
- At the very end: remove the
web-app-backuppackage from this PR. After it has been merged, we need to publish a newweb-pkgpackage and then create a PR with theweb-app-backuppackage in the CERN repo.
| </template> | ||
| </oc-breadcrumb> | ||
| <portal-target v-if="showMobileNav" name="app.runtime.mobile.nav" /> | ||
| <slot v-if="hasSharesNavigation" name="navigation" /> |
There was a problem hiding this comment.
I think we can remove hasSharesNavigation as property and replace it with a computed that checks, if the slot navigation is given.
There was a problem hiding this comment.
Hmm maybe it makes sense to have that file in web-client, alongside with the other files that include our build... methods. @dschmidt What do you think?
There was a problem hiding this comment.
Please remove that file, we already have the types in packages/web-pkg/src/helpers/resource/ancestorMetaData.ts. Some imports need to be adjusted then of course 🙂
Some unit tests are still not happy. |
Description
Moved back up app, moved all the dependencies from web-app-files.
Related Issue
Types of changes
Checklist: